Obfuscated account id #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,7 +99,6 @@ class FlutterInappPurchase { | |||
| /// | |||
| /// `iOS` also returns subscriptions. | |||
| Future<List<IAPItem>> getProducts(List<String> skus) async { | |||
| if (skus == null || skus.contains(null)) return []; | |||
There was a problem hiding this comment.
No use as List can't be null and any element of it can't be null as well
| @@ -128,7 +127,6 @@ class FlutterInappPurchase { | |||
| /// | |||
| /// `iOS` also returns non-subscription products. | |||
| Future<List<IAPItem>> getSubscriptions(List<String> skus) async { | |||
| if (skus == null || skus.contains(null)) return []; | |||
There was a problem hiding this comment.
No use as List can't be null and any element of it can't be null as well
| @@ -587,11 +582,6 @@ class FlutterInappPurchase { | |||
| required String accessToken, | |||
| bool isSubscription = false, | |||
| }) async { | |||
| assert(packageName != null); | |||
There was a problem hiding this comment.
no use for null safety version
| @@ -642,7 +632,7 @@ class FlutterInappPurchase { | |||
| throw new ArgumentError('Unknown method ${call.method}'); | |||
| } | |||
| return Future.value(null); | |||
| } as Future<dynamic> Function(MethodCall)?); | |||
There was a problem hiding this comment.
redundant
added 3 commits
July 21, 2021 16:56
|
@bohdan1krokhmaliuk if I set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides possibility to set obfuscated account id both for apple and google