Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Podspec point to master or to the release tag? #404

Closed
abdielou opened this issue Feb 16, 2019 · 5 comments
Closed

Should Podspec point to master or to the release tag? #404

abdielou opened this issue Feb 16, 2019 · 5 comments
Labels
🍗 enhancement New feature or request 🥺 feature request Request a new feature 📱 iOS Related to iOS ❓ question Further information is requested

Comments

@abdielou
Copy link

I'm not sure if this is a problem or not. The Podspec points to master and not to the release tag. Isn't this problematic when building with older versions? When you install/update the pods, it will grab whatever is the latest, right? But, what if I'm running an older version?

https://github.com/dooboolab/react-native-iap/blob/b3cac16377c9ea4b66cbde701a65e7cc08efb36f/RNIap.podspec#L13

@hyochan hyochan added ❓ question Further information is requested 📱 iOS Related to iOS labels Feb 18, 2019
@hyochan hyochan added the 🍗 enhancement New feature or request label Mar 14, 2019
@hyochan
Copy link
Owner

hyochan commented Mar 14, 2019

We've not yet configured release branch. I will handle this.

@abdielou
Copy link
Author

@hyochan Quick question on this. Why set this to stable branch instead of the actual version tag?

@hyochan
Copy link
Owner

hyochan commented Mar 28, 2019

@abdielou Oh you are right. So you want this to be something like below.

s.source         = { :git => 'https://github.com/dooboolab/react-native-iap', :tag => "v#{s.version}" }

@hyochan
Copy link
Owner

hyochan commented Mar 28, 2019

@abdielou Do you mind giving us a PR as above if this fits your needs?

@abdielou
Copy link
Author

@hyochan thanks. Let me test out your suggestion and I'll push the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request 🥺 feature request Request a new feature 📱 iOS Related to iOS ❓ question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants