Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to build iOS project using v3 #577

Closed
varungupta85 opened this issue Jul 2, 2019 · 16 comments
Closed

Unable to build iOS project using v3 #577

varungupta85 opened this issue Jul 2, 2019 · 16 comments
Labels
🐛 bug Something isn't working 📱 iOS Related to iOS 🚶🏻 stale Stale

Comments

@varungupta85
Copy link

Version of react-native-iap

3.2.2

Version of react-native

0.59.9

Platforms you faced the error (IOS or Android or both?)

iOS

Expected behavior

Build project successfully

Actual behavior

Failing with build errors in RNIap

Tested environment (Emulator? Real Device?)

Emulator

Steps to reproduce the behavior

Add RNIap v3 to a project, perform the linking and observe the errors shown in below screenshot

Screenshot 2019-07-02 at 5 24 01 PM
@hyochan hyochan added 🐛 bug Something isn't working 📱 iOS Related to iOS labels Jul 3, 2019
hyochan added a commit that referenced this issue Jul 3, 2019
@hyochan
Fixes #577
6f0b09b
@hyochan hyochan closed this as completed in df1483d Jul 3, 2019
@hyochan
Copy link
Owner

hyochan commented Jul 3, 2019

@varungupta85 Please try 3.2.4.

@hyochan hyochan reopened this Jul 3, 2019
@hyochan
Copy link
Owner

hyochan commented Jul 3, 2019 •
edited
Loading

Ok, let's invest this problem further!

@maulikdhameliya
Copy link

maulikdhameliya commented Jul 5, 2019 •
edited
Loading

image

Guys I am also facing this build problem with

Xcode Version 10.1 (10B61) 
"react-native-iap": "^3.2.4",

@varungupta85
Copy link
Author

@hyochan Like other people have reported, I also updated to 3.2.4 and still observing the same problem.

@vuitv
Copy link

vuitv commented Jul 7, 2019

I have same problem

@maulikdhameliya
Copy link

I have to downgrade to "react-native-iap": "2.4.0" to fix build error

@sshallow
Copy link

sshallow commented Jul 18, 2019 •
edited
Loading

I also encountered this problem, I saw that others solved it by downgrading, but the author suggested using version 3.2.0. I should downgrade or wait to fix this bug？
xcode:10.1
"react-native": "^0.59.10",
"react-native-iap": "^3.3.2",

@hyochan
Copy link
Owner

hyochan commented Jul 18, 2019

image

I can't reproduce this in my env. So please generate minimal reproduction maybe sharing some codes.

@paolospag
Copy link

For me, the problem is Xcode: updating from 10.1 to 10.2.1 'm able to build correctly, but honestly I don't know if it works with iOS versions <= 12.1

ming436534 pushed a commit to ming436534/react-native-iap that referenced this issue Jul 19, 2019
Merge branch 'master' of https://github.com/dooboolab/react-native-iap
f484ebb 
* 'master' of https://github.com/dooboolab/react-native-iap: (107 commits)
  Release 3.3.4
  Keep valid SKUs in memory
  chore(package): update flow-bin to version 0.103.0
  Fixes hyochan#600
  Added missing types on updates in 3.3.0
  chore(package): update @types/react-native to version 0.60.2
  Release 3.3.1 (hyochan#596)
  Update travis with yarn
  Fix flow type for purchaseUpdatedListener
  Upgrade example project rn version
  chore(package): update @types/react-native to version 0.60.1
  Fix hyochan#581 finishTransaction called automatically (hyochan#589)
  Update index.js.flow
  chore(package): update lockfile yarn.lock
  chore(package): update @types/react-native to version 0.60.0
  chore(package): update lockfile yarn.lock
  chore(package): update @types/react to version 16.8.23
  Fixes hyochan#577 (hyochan#578)
  Update @types/react-native to the latest version 🚀 (hyochan#575)
  Improve README (hyochan#574)
  ...

# Conflicts:
#	ios/RNIapIos.m
@lc3t35
Copy link

lc3t35 commented Jul 23, 2019

Any news about that issue ?

@quyen91
Copy link

quyen91 commented Aug 8, 2019

I am using Xcode 10.1 and same error occur. Then I update Xcode to 10.3. Xcode built successfully.

@ironworkshop
Copy link

ironworkshop commented Aug 9, 2019 •
edited
Loading

Running into the same issue, on Xcode 10.1, going to get Xcode 10.3 dmg and run side by side to see if it solves it.

Update: After a full update to Mojave and Xcode 10.3 the build seems to be working.

@maulikdhameliya
Copy link

@hyochan this issue seems to be compatible with Xcode > 10.2
Can we make it compatible with 10.1 please since many users can't upgrade their Xcode due to the limitation of upgrading OS ?

@doomsower doomsower mentioned this issue Aug 17, 2019
Merged
@lc3t35
Copy link

lc3t35 commented Aug 25, 2019

Thank you very much @doomsower, works fine on my side with XCode Version 10.1 (10B61) and rn-iap 3.4.0.

@stale
Copy link

stale bot commented Dec 25, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the 🚶🏻 stale Stale label Dec 25, 2019
@stale
Copy link

stale bot commented Jan 24, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 📱 iOS Related to iOS 🚶🏻 stale Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@lc3t35 @quyen91 @varungupta85 @maulikdhameliya @ironworkshop @vuitv @sshallow @hyochan @paolospag and others