Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of getPromotedProductIOS #1037

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Fix return type of getPromotedProductIOS #1037

merged 1 commit into from
Jul 4, 2020

Conversation

ouabing
Copy link
Contributor

@ouabing ouabing commented Jul 1, 2020

The OC code returns productIdentifier which is a string type.

hyochan
hyochan approved these changes Jul 4, 2020
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hyochan hyochan merged commit 3fed16b into hyochan:master Jul 4, 2020
@hyochan hyochan added the ❄️ types Typing issues label Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
❄️ types Typing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouabing @hyochan