Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Be more specific in purchaseErrorListener param typing #1101

Merged
merged 2 commits into from
Sep 14, 2020
Merged

test: Be more specific in purchaseErrorListener param typing #1101

merged 2 commits into from
Sep 14, 2020

Conversation

AmauryLiet
Copy link
Contributor

Not sure of the reason why any was here at the beginning. Any clue?

hyochan
hyochan approved these changes Sep 14, 2020
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite remember currently 😢
However, looks like this is much safer. So let's take it 💯

@hyochan hyochan added the ❄️ types Typing issues label Sep 14, 2020
@hyochan hyochan merged commit 8240bc4 into hyochan:master Sep 14, 2020
@AmauryLiet AmauryLiet deleted the feat/be-more-specific-in-purchaseErrorListener-typing branch September 14, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
❄️ types Typing issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmauryLiet @hyochan