Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade android billing sdk to v3 #1112

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Upgrade android billing sdk to v3 #1112

merged 4 commits into from
Sep 16, 2020

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Sep 16, 2020

Resolve #1061

@hyochan hyochan added 🤖 android Related to android upgrade labels Sep 16, 2020
@hyochan hyochan merged commit b5e00d7 into master Sep 16, 2020
@hyochan hyochan deleted the upgrade-billing-sdk branch September 16, 2020 12:55
@mars-lan
Copy link
Contributor

Something like this is considered "breaking" and warrants a major version bump based on semver.

@hyochan
Copy link
Owner Author

hyochan commented Oct 2, 2020

@mars-lan Could you kindly explain further on this? How I might have to handle this in the future?

@mars-lan
Copy link
Contributor

mars-lan commented Oct 3, 2020

@hyochan you removed developerIdAndroid & accountIdAndroid params from requestPurchase & requestSubscription functions, which is a breaking change. Based on SemVer you should have bumped up the major version to 5.0.0 instead of the minor version.

@hyochan
Copy link
Owner Author

hyochan commented Oct 3, 2020

@mars-lan Thanks for the detail! I'll make sure for this next time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖 android Related to android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Play Billing Library 3.0
2 participants
@hyochan @mars-lan