Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Xcode 12 compatibility #1115

Merged
merged 1 commit into from
Sep 20, 2020
Merged

fix: Xcode 12 compatibility #1115

merged 1 commit into from
Sep 20, 2020

Conversation

radko93
Copy link
Contributor

@radko93 radko93 commented Sep 17, 2020

Latest Xcode 12 fails to build without a module to depend on React-Core directly hence this change is necessary for all native modules on iOS. This change requires React Native 0.60.2 or newer. For more details please check: facebook/react-native#29633 (comment)

@hyochan hyochan added 🛠 bugfix All kinds of bug fixes 🚽 migration Activities due to changes in framework labels Sep 20, 2020
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it 👍

@hyochan hyochan merged commit 9756a0d into hyochan:master Sep 20, 2020
@radko93 radko93 deleted the patch-1 branch September 20, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 bugfix All kinds of bug fixes 🚽 migration Activities due to changes in framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants