Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iOS store country code #1186

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Add iOS store country code #1186

merged 2 commits into from
Nov 21, 2020

Conversation

jochem725
Copy link
Contributor

This adds the App Store country code to iOS

@Klaasvaak
Copy link

We would like to move from react-native-in-app-utils and this missing attribute is stopping us from making that move.

hyochan
hyochan approved these changes Nov 21, 2020
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

@hyochan hyochan added the 🎯 feature New feature label Nov 21, 2020
@hyochan hyochan merged commit 8a2d0d9 into hyochan:master Nov 21, 2020
hyochan added a commit that referenced this pull request Nov 21, 2020
@hyochan
Release 5.1.2
ab25d81 
Lint fixes & applied #1186 #1182
@leethree leethree mentioned this pull request Jan 8, 2021
Closed
ninjaboy added a commit to ninjaboy/react-native-iap that referenced this pull request Feb 6, 2021
@ninjaboy
Revert "Add iOS store country code (hyochan#1186)"
f180182 
This reverts commit 8a2d0d9.
@ninjaboy ninjaboy mentioned this pull request Feb 6, 2021
Closed
@ninjaboy
Copy link
Contributor

ninjaboy commented Feb 6, 2021

@jochem725, seems like this change is causing empty fields for products to happen randomly. I have started observing this as well as many people reported in #1203. Do you have any idea on what can be causing this?

@jochem725
Copy link
Contributor Author

@ninjaboy Yes. What happens is that countryCode somehow ends up being nil, everything after nil is not added to the NSDictionary. I created #1246 which should prevent this from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🎯 feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jochem725 @Klaasvaak @ninjaboy @hyochan