Update build.gradle #213
Merged
Update build.gradle #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fallback when rootProject ext does not contain sdk- and compile-versions
|
Thanks |
|
Hey, I am wondering why it needs min API version 26. Looking at the current distribution shares that's apparently cutting of 90% of the market. |
|
Okay, I double checked the changes… it seems that is is now supposed to pull minSdkVersion and so on from the project's config. Unfortunately, however, it does not work for me. I guess it related to #215 FYI: I am staying at version 1.2.4 for now, which works fine fore me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defaults fallback when rootProject.ext does not contain sdk- and compile-versions.
the parameters
compileSdkVersion,buildToolsVersion,minSdkVersionandtargetSdkVersionwere not available in the Root project of my project. Adding a standard fallback to thebuild.gradleensures that the react-native-iap package can always compile for everyone.