Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call correct methods in finishTransaction Android #778

Merged
merged 1 commit into from
Oct 9, 2019
Merged

fix: call correct methods in finishTransaction Android #778

merged 1 commit into from
Oct 9, 2019

Conversation

doomsower
Copy link
Contributor

finishTransaction on Android calls non-existing native methods. This should fix it.

hyochan
hyochan approved these changes Oct 9, 2019
View reviewed changes
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t believe I’ve missed this! Thank you!

@hyochan hyochan merged commit 2572d56 into hyochan:master Oct 9, 2019
@hyochan hyochan added the 🛠 bugfix All kinds of bug fixes label Oct 9, 2019
@hyochan hyochan mentioned this pull request Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyochan hyochan hyochan approved these changes

Assignees
No one assigned
Labels
🛠 bugfix All kinds of bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doomsower @hyochan