Theme Request: Fairyfloss

[JuneKelly]

Main github repo: http://sailorhg.github.io/fairyfloss

Example screenshot:

There is a partial conversion for emacs here: sailorhg/fairyfloss#3, but it's got some weird colors going on in places like the magit UI.

[ema2159]

If Mr. Lissner lets me, I'll implement this one

[ema2159]

I have green lights now so expect to see this soon 😁

[ema2159]

Almost there!

[ema2159]

Done, it's been added. I almost got diabetes implementing this jaja! Please test it and tell me if you find any weird faces. I used it and didn't found any issues besides some magit faces which I fixed

[JuneKelly]

Very nice, thanks!

I'm testing on spacemacs, and it all looks very good so far. One small point, maybe the current-line highlight is a little too strong? Maybe that's just a personal preference.

Otherwise, this looks real nice, 🎉

[ema2159]

That's using hl-line? If it is, then yes, it's too strong. I'll check in VS Code and use the same color

[ema2159]

@ShaneKilkelly done, It's now lighter and smoother. Report here if you find more things like that!

[JuneKelly]

Thanks!

[chase-dwelle]

Surprised that I like the theme as much as I do. One question though, I have this blue color ("blue" -- #268bd2 in the theme) that I have not seen in any of the screenshots that does not have enough contrast with the background (can be seen with the infile = open(rfile, 'rb') line in the attached

Personally I think something like #85f3bc, a pastel green, is easier to differentiate from the background:

Is this something that can be changed, or is the original "blue" color preferred by most?

[ema2159]

You're right. I don't quite remember where I took that blue from. Although a pastel green would do the work, I personally think it would be better to find a blue alternative, given that it's the blue variable what we're changing.

[ema2159]

@chase-dwelle how about this color I just made up (lol)?:
#55b3cc
It's still blueish while having a much better contrast .

[chase-dwelle]

Yes that works; here it is in the same screenshot.

[ema2159]

Done, it should be up in the next update

[chase-dwelle]

Found some other issues with font faces in org-mode, especially with scheduled faces. The inherited faces from the base theme end up with nearly the same color in scheduled faces and the background. I suggest borrowing from doom-dracula:

   (org-scheduled :foreground green)
   (org-scheduled-previously :foreground yellow)
   (org-scheduled-today :foreground orange) 

[ema2159]

Hi @chase-dwelle!, Would you please show me an screenshot?

[chase-dwelle]

Here is my screenshot using the base fairy floss theme:

Borrowing the following definitions from doom-dracula gives the image below. I'm guessing that there are some font face decisions in the base theme that can lead to lack of readability in some of the darker themes, which is why doom-dracula has so defined faces.

   (org-scheduled :foreground green)
   (org-scheduled-previously :foreground yellow)
   (org-scheduled-today :foreground orange)

[ema2159]

@chase-dwelle sorry for the late reply. How about now?

[chase-dwelle]

Yes works well. Thanks you!