Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit EMA: Research about how the old Edit Page Nav Bar works #26960

Closed
Tracked by #26644
zJaaal opened this issue Dec 11, 2023 · 2 comments
Closed
Tracked by #26644

Edit EMA: Research about how the old Edit Page Nav Bar works #26960

zJaaal opened this issue Dec 11, 2023 · 2 comments

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Dec 11, 2023

Parent Issue

#26644

Task

Take notes about how we get to the different portlets/dialogs/side panels, inside the edit-page. We need to make a decision of how are we going to implement this Nav Bar based on the result of this ticket.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@fmontes
Copy link
Member

fmontes commented Dec 11, 2023

Timeboxed: 1h

@zJaaal
Copy link
Contributor Author

zJaaal commented Dec 11, 2023

Findings

  • The current Nav Bar does not depend on anything but the Router of that portlet. So it can be safe to re-make it, since all is handled by the portlets in the routes.
  • Since most of the routes are already libraries, we don't have to move anything outside of the edit-page but we have to move an small component that holds some SEO Tools, it looks really self contained so it shouldn't take much time to do it.
  • At this point of research, if we are going to re-make the Nav Bar we must re-do two things:
    1. The Nav Bar as UI and logic to conditional render items based on feature flags and license status.
    2. The routing to make it work similar as the current one in edit-page

Conclusions

By re-doing the Nav Bar we can save time in moving some services that are contained by the nav bar. Also we have the opportunity to clean some code that is not needed due to new implemented features, as the new Template Builder.

We are also considering the use of side panels as our main tool to render this portlets, therefore by redoing the Nav Bar and the router module, we have more control of the functionality of it and it's easier to explore and test this possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants