Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Page V2: Bring back tinymce inline editing to the new page editor for VTL Pages #28196

Closed
2 tasks
Tracked by #27546
fmontes opened this issue Apr 11, 2024 · 5 comments · Fixed by #28195, #28315, #28336 or #28358
Closed
2 tasks
Tracked by #27546

Comments

@fmontes
Copy link
Member

fmontes commented Apr 11, 2024

Parent

#27546

Task description

As a dotCMS user, I want to be able to inline edit the page in the new page editor without changing anything in my code. This feature was available in the previous version, and we need to support our previous API to ensure a seamless transition for users.

Acceptance Criteria

Preview Give feedback

External Links

N/A

Assumptions & Initiation Needs

This task doesn't include block editor inline editing, that will be in another task

Quality Assurance Notes & Workarounds

N/A

@fmontes fmontes changed the title Edit Page V2: Bring back inline editing to the new page editor Edit Page V2: Bring back tinymce inline editing to the new page editor Apr 11, 2024
@fmontes fmontes self-assigned this Apr 11, 2024
@fmontes fmontes moved this from New to In Progress in dotCMS - Product Planning Apr 11, 2024
@fmontes fmontes linked a pull request Apr 11, 2024 that will close this issue
@fmontes fmontes removed their assignment Apr 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Internal QA in dotCMS - Product Planning Apr 19, 2024
@fmontes fmontes self-assigned this Apr 22, 2024
@fmontes
Copy link
Member Author

fmontes commented Apr 22, 2024

inline-edit-2.mp4

@rjvelazco
Copy link
Contributor

Falid Internal QA

  • Tested on Docker: [dotcms/dotcms:docker]
  1. Autosave is not working
  2. Missing editpage.content.update.success & editpage.content.update.error messages keys.

Video

Screen.Recording.2024-04-23.at.4.13.12.PM.mov

@rjvelazco rjvelazco linked a pull request Apr 24, 2024 that will close this issue
@rjvelazco
Copy link
Contributor

rjvelazco commented Apr 24, 2024

Fail Internal QA

  • Tested on Docker: [dotcms/trunk_6947043]

Steps to Reproduce

  1. Go to the new Edit Page.
  2. Add a Rich Text or any contenttype with a WYSIWYG.
  3. Edit the WYSIWYG field by inline editing.
  4. Click on the edit button [The one with the pencil icon].
  5. See the error.

The modal is being opened with an old `contentlet version.

Video

Screen.Recording.2024-04-24.at.6.24.24.PM-1.mov

@zJaaal zJaaal moved this from Internal QA to In Progress in dotCMS - Product Planning Apr 25, 2024
@zJaaal zJaaal linked a pull request Apr 25, 2024 that will close this issue
@KevinDavilaDotCMS KevinDavilaDotCMS moved this from In Progress to Internal QA in dotCMS - Product Planning Apr 30, 2024
@rjvelazco
Copy link
Contributor

Passed Internal QA

  • Tested on Docker: [dotcms/trunk_ 2b727f8]

Video

fix-uve-inline-editor-1.mov

@rjvelazco rjvelazco changed the title Edit Page V2: Bring back tinymce inline editing to the new page editor Edit Page V2: Bring back tinymce inline editing to the new page editor for VTL Pages May 1, 2024
@rjvelazco rjvelazco moved this from Internal QA to QA - Backlog in dotCMS - Product Planning May 1, 2024
@josemejias11 josemejias11 moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning May 1, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_cbce59a, Docker, macOS 13.0, FF v124.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment