Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Page 2: Allow Users to scroll while dragging #28469

Closed
1 task
KevinDavilaDotCMS opened this issue May 7, 2024 · 7 comments · Fixed by #28419, #28491 or #28518
Closed
1 task

Edit Page 2: Allow Users to scroll while dragging #28469

KevinDavilaDotCMS opened this issue May 7, 2024 · 7 comments · Fixed by #28419, #28491 or #28518

Comments

@KevinDavilaDotCMS
Copy link
Contributor

Parent Issue

#26644

Task

  • Enable the user to scroll inside the iframe page while dragging from palette, outside of browser like dot-asset or move contentlets

Proposed Objective

Same as Parent Issue

Proposed Priority

Priority 2 - Important

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@zJaaal
Copy link
Contributor

zJaaal commented May 9, 2024

IQA Failed

When we reach the edge of the iframe we get stuck in a bad state and we are unable to drop something in the editor.

Screenshot

Screen.Recording.2024-05-09.at.12.48.02.PM.mov

@zJaaal zJaaal moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning May 9, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning May 10, 2024
@zJaaal
Copy link
Contributor

zJaaal commented May 16, 2024

IQA Failed

The editor works as expected, but i'm not able to drop anything close to the zone of scroll when im on the edge

Screenshots

Headless Chromium Cross Origin

Screen.Recording.2024-05-16.at.4.39.07.PM.mov

@zJaaal zJaaal moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning May 16, 2024
@KevinDavilaDotCMS
Copy link
Contributor Author

That will happen when there is a contentlet within the first or last 100 px, it definitely needs to be corrected but perhaps it can be in a different ticket and we add some more cases that we find?
thoughts? cc @fmontes

@fmontes
Copy link
Member

fmontes commented May 17, 2024

@zJaaal @KevinDavilaDotCMS let's move on with this, very edge case, Kevin please create a ticket for this case.

@KevinDavilaDotCMS
Copy link
Contributor Author

Ok, so this is an expected issue that will be resolved in #28601
Waiting for the IQA Passed on the currently ticket

@zJaaal
Copy link
Contributor

zJaaal commented May 20, 2024

Note to QA

I didn't find any other issues so we can pass the IQA.

@zJaaal zJaaal moved this from Current Sprint Backlog to QA - Backlog in dotCMS - Product Planning May 20, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning May 22, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_8b71ba0, Docker, macOS 13.0, FF v124.0.2

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment