Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect code formatting in Tab.razor example #30157

Closed
TheAtomicOption opened this issue Aug 25, 2023 · 4 comments
Closed

Incorrect code formatting in Tab.razor example #30157

TheAtomicOption opened this issue Aug 25, 2023 · 4 comments
Assignees
Labels
Blazor docs-experience Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@TheAtomicOption
Copy link

In the "Pass data across a component hierarchy" section, the code for Tab.razor has incorrect syntax highlighting for the closing html tags and much of the @code { } block.

This appears to be a failure to switch back to expecting html from expecting csharp when parsing the closing quote at the end of class="nav-link @TitleCssClass". Changing to class="nav-link @(TitleCssClass)" might avoid this parsing error.


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added Blazor Source - Docs.ms Docs Customer feedback via GitHub Issue labels Aug 25, 2023
@guardrex
Copy link
Collaborator

guardrex commented Aug 25, 2023

Thanks for the report, @TheAtomicOption.

@guardrex
Copy link
Collaborator

guardrex commented Aug 25, 2023

It appears to only be a doc highlight parsing problem. IntelliSense is cool with it.

@Rick-Anderson ... I'd prefer not to change the code just to make the doc parser work better because this is valid Razor code. Can this be opened for SiteHelp as an internal docs bug?

Bad doc highlighting

Screenshot 2023-08-25 163100

IntelliSense 😎

image

@guardrex
Copy link
Collaborator

guardrex commented Sep 5, 2023

@Rick-Anderson ... Should this be opened internally? The Razor code is correct, but the docs parser can't handle it.

@guardrex
Copy link
Collaborator

guardrex commented Oct 2, 2023

@Rick-Anderson ... Was this opened internally? If so, should I leave this open just for tracking? I fear that if I close it that I'll forget to check back in a few months to see if this has been fixed. However, I could just enter this on my tracking issue as a bullet item ... yeah 🤔 ... that's best. I'm going to close this and track it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blazor docs-experience Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
Archived in project
Development

No branches or pull requests

3 participants