Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing default credentials to a proxy #305

Closed
mungojam opened this issue Dec 2, 2019 · 5 comments · Fixed by #408
Closed

Support passing default credentials to a proxy #305

mungojam opened this issue Dec 2, 2019 · 5 comments · Fixed by #408
Labels
5.0-dash Potential final items for 5.0
Milestone

Comments

@mungojam
Copy link

mungojam commented Dec 2, 2019

We are behind a corporate proxy and so the tool isn't currently usable for us which is a shame as it's great :)

@tlmii tlmii added the enhancement New feature or request label Dec 3, 2019
@bradygaster bradygaster added this to the 3.2 milestone Jun 22, 2020
@tlmii
Copy link
Member

tlmii commented Jun 29, 2020

Sorry it's taken us a while to get back to you.

Default proxy support should already be in the tool. Under the hood, we're using HttpClient, and that picks up the DefaultProxy automatically. I'll get that added to the documentation, but I'm curious what issues you ran into with your corporate proxy. It should just pick up your system proxy, but you can also configure it directly via environment variables (see the Remarks section of the DefaultProxy docs).

@tlmii tlmii added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jun 29, 2020
@tlmii tlmii modified the milestones: 3.2, 3.1 Jun 29, 2020
@tlmii tlmii modified the milestones: 3.1, 5.0.0 Oct 22, 2020
@tlmii tlmii added the 5.0-dash Potential final items for 5.0 label Oct 22, 2020
@tlmii
Copy link
Member

tlmii commented Oct 22, 2020

@mungojam Just following up here. I still need to get this added to the documentation. But do you have any additional details on what issues you ran into?

@mungojam
Copy link
Author

Hiya, sorry haven't got around to looking into it again. I think the issue is more if you have a Windows authenticated proxy. .net core requires a one-liner to tell it to use the default credentials for the proxy but I'm not at my computer to point you to it. Will try to later 🙂

@mungojam
Copy link
Author

You can see how it was added to sleet (following my request):

emgarten/Sleet#126

@tlmii
Copy link
Member

tlmii commented Oct 22, 2020

@mungojam Ah, so its the auth side that's the problem, not the use of the proxy itself. That makes sense.

Thanks for the link. We've already got default cred support for the APIs themselves, It should be easy to add the call for the proxy too. Looks like we'll need a new preference (probably httpClient.proxy.useDefaultCredentials or similar) and then adding it when we construct the handler in GetHttpClientWithPreferences.

I'll see if we can sneak that in before 5.0

@tlmii tlmii changed the title Please add default proxy support (or documentation on how to enable it) Support passing default credentials to a proxy Oct 22, 2020
@tlmii tlmii removed the documentation Improvements or additions to documentation label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0-dash Potential final items for 5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants