Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Stream and TextReader to be retrieved by GetFieldValue and GetFieldValueAsync #732

Closed
roji opened this issue Sep 20, 2020 · 2 comments
Closed

Allow Stream and TextReader to be retrieved by GetFieldValue and GetFieldValueAsync #732

roji opened this issue Sep 20, 2020 · 2 comments
Labels
💡 Enhancement Issues that are feature requests for the drivers we maintain.

Comments

@roji
Copy link
Member

roji commented Sep 20, 2020 •
edited
Loading

As per discussion in dotnet/runtime#28596 (comment), there are currently no async counterparts to DbDataReader.Get{Stream,TextReader}. Rather than adding new methods, it seems better to just allow these types to be returned from DbDataReader.GetFieldValue (and Async).

Added tests to @bgrainger's AdoNetApiTest for Stream: mysql-net/AdoNetApiTest#145

/cc @Wraith2
@roji roji mentioned this issue Sep 20, 2020
Merged
@JRahnama JRahnama added the 💡 Enhancement Issues that are feature requests for the drivers we maintain. label Sep 21, 2020
@cheenamalhotra
Copy link
Member

Acknowledged for future.

@David-Engel
Copy link
Contributor

Seems like this was covered/completed by the implementation in #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 Enhancement Issues that are feature requests for the drivers we maintain.
Projects
SqlClient Triage Board
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@roji @cheenamalhotra @David-Engel @JRahnama