Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource grid: Use "Logs" rather than "View" in the logs column #2148

Closed
drewnoakes opened this issue Feb 9, 2024 · 7 comments
Closed

Resource grid: Use "Logs" rather than "View" in the logs column #2148

drewnoakes opened this issue Feb 9, 2024 · 7 comments
Assignees
Milestone

Comments

@drewnoakes
Copy link
Member

A few ideas for improvements to this part of the table:

image

The "Logs" and "Details" columns both contain "View" buttons. If logs column buttons read "Logs", it'd be easier to know which button to click when scanning left-to-right from the resource name at the far side of the table.

As it stands, you have to scan left-to-right, then up the table, then back down. If you have many resources, it can be a long way to the top, and you can lose track of which row you were on, so scan back left again to validate.

image

@kvenkatrajan
Copy link
Member

@leslierichardson95 thoughts on verbiage here?

@leslierichardson95
Copy link

I agree the name should be changed from "View" to something else, but I feel like just "Logs" doesn't differentiate from the Logs header all that much (I'd suggest "view logs" but that would take up more space). That said, we can go with "Logs" until one of us comes up with something better. :)

@davidfowl
Copy link
Member

Assigning to you @leslierichardson95

@kvenkatrajan
Copy link
Member

@leslierichardson95 moving this to preview 6 - please confirm verbiage.

@davidfowl davidfowl modified the milestones: preview 6 (Apr), 8.1 Apr 16, 2024
@leslierichardson95
Copy link

For now, let's replace "View" with "logs" and "Details" and make sure the a11y tooltips give specific details about what resource that particular link is corresponding to.

@kvenkatrajan kvenkatrajan modified the milestones: 8.1, 8.2 Jun 24, 2024
@drewnoakes drewnoakes modified the milestones: 8.2, 9.0 Aug 23, 2024
@davidfowl
Copy link
Member

Is this still relevant now that we have #5516?

@drewnoakes
Copy link
Member Author

We no longer need this.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants