Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: allow logs to flow into test output #2790

Closed
ReubenBond opened this issue Mar 11, 2024 · 3 comments · Fixed by #4444
Closed

Testing: allow logs to flow into test output #2790

ReubenBond opened this issue Mar 11, 2024 · 3 comments · Fixed by #4444
Assignees
@DamianEdwards
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Comments

@ReubenBond
Copy link
Member

ReubenBond commented Mar 11, 2024 •
edited
Loading

When developers use Aspire.Hosting.Testing, they would benefit from seeing logs in test output. We should add this. Logs are accessible via Aspire.Hosting.ResourceLoggerService. See also ResourceNotificationService
@ReubenBond ReubenBond added this to the preview 5 (Apr) milestone Mar 11, 2024
@ReubenBond ReubenBond self-assigned this Mar 11, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 11, 2024
@ReubenBond ReubenBond mentioned this issue Mar 11, 2024
Closed
@davidfowl davidfowl modified the milestones: preview 5 (Apr), Backlog Mar 27, 2024
@davidfowl
Copy link
Member

We're going to move this to the backlog and instead write a sample showing how to flow logs via xunit's ITestOutputHelper.

@DamianEdwards
Copy link
Member

Can you update the issue to add a testing sample in the samples repo please to capture this?

@davidfowl
Copy link
Member

dotnet/aspire-samples#164

@DamianEdwards DamianEdwards modified the milestones: Backlog, 8.1 Jun 14, 2024
@DamianEdwards DamianEdwards mentioned this issue Jun 14, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DamianEdwards DamianEdwards

Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to Aspire.Hosting.Testing dotnet/aspire
3 participants
@davidfowl @ReubenBond @DamianEdwards