Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Razor] Bring back RazorLangversion 6.0 #32672

Closed
javiercn opened this issue May 14, 2021 · 5 comments
Closed

[Razor] Bring back RazorLangversion 6.0 #32672

javiercn opened this issue May 14, 2021 · 5 comments

Comments

@javiercn
Copy link
Member

We undid the change for adding a new RazorLangVersion because we thought it would resolve some build/stability issues that we were observing on the build. Undoing the change didn't seem to fix the issue, so we should try and bring back the change and solve the underlying root cause.

This issue tracks the work for "re-reverting the commits" on the SDK and the razor compiler as well as updating the codebase in all places where its necessary to key off functionality of RazorLangVersion 6.0:

  • Generic type constraints
  • Generic parameters type inference
  • JS Modules
@captainsafia
Copy link
Member

captainsafia commented May 14, 2021

@javiercn We can do this once #32581 is in which attempts to resolve the generic params issue by disabling the RSG for projects where it is throwing errors.

EDIT: Actually, we don't need to wait for that PR. We can do it in parallel.

@javiercn
Copy link
Member Author

@captainsafia If you want to do it, go ahead.

I don't think we have any rush to bump the version, just filed an issue to make sure we keep track of it and have a place to put all the things we need to key of of this.

@captainsafia
Copy link
Member

Now that we're on the new SDK, let's give it a couple of days to see how things fare with the build issues.

@mkArtakMSFT mkArtakMSFT added enhancement This issue represents an ask for new feature or an enhancement to an existing one task labels May 17, 2021
@mkArtakMSFT mkArtakMSFT added this to the 6.0-preview5 milestone May 17, 2021
@danroth27 danroth27 removed the enhancement This issue represents an ask for new feature or an enhancement to an existing one label May 17, 2021
@ghost
Copy link

ghost commented May 17, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT mkArtakMSFT added enhancement This issue represents an ask for new feature or an enhancement to an existing one and removed enhancement This issue represents an ask for new feature or an enhancement to an existing one labels May 17, 2021
@mkArtakMSFT mkArtakMSFT assigned captainsafia and unassigned javiercn Jul 8, 2021
@mkArtakMSFT
Copy link
Member

Thank you @captainsafia for agreeing to help with this issue. This will help @javier with his backlog in current milestone.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants