Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enhancements to MVC for a grow up story from minimal actions #33403

Closed
6 tasks done
pranavkm opened this issue Jun 9, 2021 · 7 comments
Closed
6 tasks done
Assignees
Labels
area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels feature-model-binding Priority:0 Work that we can't release without Status: Resolved triage-focus Add this label to flag the issue for focus at triage
Milestone

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Jun 9, 2021

We'd likely have an option specifically for FromServices behavior rather than a global EnableMinimalAPICompatibilityMode

@pranavkm
Copy link
Contributor Author

pranavkm commented Jun 9, 2021

FYI @davidfowl / @halter73

@pranavkm pranavkm added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 9, 2021
@pranavkm pranavkm added this to the 6.0-preview7 milestone Jun 9, 2021
@ghost
Copy link

ghost commented Jun 15, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT mkArtakMSFT added the feature-minimal-actions Controller-like actions for endpoint routing label Jun 15, 2021
@halter73 halter73 modified the milestones: Next sprint planning, 6.0-rc1 Jul 8, 2021
@rafikiassumani-msft rafikiassumani-msft added the Priority:1 Work that is critical for the release, but we could probably ship without label Jul 20, 2021
@davidfowl davidfowl added the area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Jul 31, 2021
@rafikiassumani-msft rafikiassumani-msft modified the milestones: 6.0-rc1, 6.0-rc2 Aug 26, 2021
@davidfowl
Copy link
Member

@pranavkm I moved the implicit services for MVC below the cutline. I think we should do the analyzer here that warns if you return an IResult from an MVC controller.

@mkArtakMSFT mkArtakMSFT removed the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 16, 2021
@mkArtakMSFT
Copy link
Member

@rafikiassumani-msft do you want to handle this in 6.0 or backlog? Up to you :)

@rafikiassumani-msft rafikiassumani-msft added feature-model-binding triage-focus Add this label to flag the issue for focus at triage and removed feature-minimal-actions Controller-like actions for endpoint routing labels Jan 11, 2022
@rafikiassumani-msft rafikiassumani-msft added Priority:0 Work that we can't release without Cost:L and removed Priority:1 Work that is critical for the release, but we could probably ship without labels Jan 11, 2022
@brunolins16
Copy link
Member

@pranavkm for this item "Inferring optionality from nullability information" there is recent PR that updated the DataAnnotationsProvider to use the NullabilityContext #39219.

Is that enough? If not, can you just give me a briefly explanation about this item?

@pranavkm
Copy link
Contributor Author

@brunolins16 it's about supporting https://docs.microsoft.com/en-us/aspnet/core/fundamentals/minimal-apis?view=aspnetcore-6.0#optional-parameters. Essentially make `

#nullable enable
public IActionResult Post(string? value);

the same as

#nullable disable
public IActionResult Post(string value = null);

@brunolins16
Copy link
Member

@pranavkm I thought it was already supported. Let me test it. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels feature-model-binding Priority:0 Work that we can't release without Status: Resolved triage-focus Add this label to flag the issue for focus at triage
Projects
None yet
Development

No branches or pull requests

7 participants