Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup remaining issues in StreamPipeReader/StreamPipeWriter #4344

Closed
2 of 7 tasks
jkotalik opened this issue Nov 30, 2018 · 7 comments
Closed
2 of 7 tasks

Cleanup remaining issues in StreamPipeReader/StreamPipeWriter #4344

jkotalik opened this issue Nov 30, 2018 · 7 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blocked The work on this issue is blocked due to some dependency feature-pipelines Anything relating to exposing/using Pipes in ASP.NET Core triage-focus Add this label to flag the issue for focus at triage
Milestone
3.0.0-preview5

Comments

@jkotalik
Copy link
Contributor

jkotalik commented Nov 30, 2018 •
edited by analogrelay
Loading

Epic #8829

There are a few more issues that need to be addressed:

  • Add MaxBufferSize setting
  • OnReaderCompleted
  • OnWriterCompleted
  • Throw on overlapping Reads/Flush
  • Refactor ReadAsync to avoid an extra async state machine.
  • Creating a new tail segment if we have consumed a certain percentage of the segment.
  • Remove _completedSegments.RemoveAt(0); from StreamPipeWriter
@jkotalik jkotalik self-assigned this Nov 30, 2018
@davidfowl davidfowl added this to the 3.0.0-preview2 milestone Dec 1, 2018
@jkotalik jkotalik mentioned this issue Dec 3, 2018
Merged
@muratg muratg modified the milestones: 3.0.0-preview2, 3.0.0-preview3 Jan 30, 2019
@jkotalik jkotalik added the feature-pipelines Anything relating to exposing/using Pipes in ASP.NET Core label Feb 21, 2019
@muratg muratg modified the milestones: 3.0.0-preview3, 3.0.0-preview4 Feb 27, 2019
@muratg muratg assigned davidfowl and unassigned jkotalik Feb 27, 2019
@analogrelay
Copy link
Contributor

What's the story here? @jkotalik @davidfowl

@jkotalik
Copy link
Contributor Author

Let's put this to the next preview. A lot of these types may change based on discussions with Corefx.

@analogrelay analogrelay mentioned this issue Mar 26, 2019
Closed
1 task
@analogrelay analogrelay added the blocked The work on this issue is blocked due to some dependency label Mar 27, 2019
@analogrelay
Copy link
Contributor

This is dependent upon all the corefx discussions.

@analogrelay
Copy link
Contributor

Let's clarify the situation here in triage today.

@analogrelay analogrelay added the triage-focus Add this label to flag the issue for focus at triage label Apr 9, 2019
@davidfowl
Copy link
Member

We should change this bug to reflect the new plan (as casting with interfaces).

@analogrelay
Copy link
Contributor

Perhaps not this one, but yes, we'll revisit the epic to make sure it has issues tracking the right work.

@analogrelay
Copy link
Contributor

Closing in lieu of #9223

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blocked The work on this issue is blocked due to some dependency feature-pipelines Anything relating to exposing/using Pipes in ASP.NET Core triage-focus Add this label to flag the issue for focus at triage
Projects
None yet
Milestone
3.0.0-preview5
Development

No branches or pull requests
5 participants
@analogrelay @davidfowl @muratg @jkotalik @amcasey