Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-ASCII characters in response header values #4727

Closed
JunTaoLuo opened this issue Sep 5, 2018 · 6 comments · Fixed by #33776
Closed

Allow non-ASCII characters in response header values #4727

JunTaoLuo opened this issue Sep 5, 2018 · 6 comments · Fixed by #33776
Assignees
Labels
affected-few This issue impacts only small number of customers api-suggestion Early API idea and discussion, it is NOT ready for implementation area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-kestrel help wanted Up for grabs. We would accept a PR to help resolve this issue severity-major This label is used by an internal tool
Milestone

Comments

@JunTaoLuo
Copy link
Contributor

Following up for aspnet/KestrelHttpServer#1144. We may want to allow UTF-8 characters in response header values now to parallel our acceptance of UTF-8 characters in request header values. Note that the app has some degree of control over the response headers and their values.

@Tratcher
Copy link
Member

Tratcher commented Sep 7, 2018

@davidfowl this doesn't seem as urgent as the app has control of the response headers. Punting to 3.0.

@davidfowl
Copy link
Member

Seems fine.

@aspnet-hello aspnet-hello transferred this issue from aspnet/KestrelHttpServer Dec 13, 2018
@aspnet-hello aspnet-hello added this to the Backlog milestone Dec 13, 2018
@aspnet-hello aspnet-hello added area-servers enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-kestrel labels Dec 13, 2018
@rickyburrell
Copy link

rickyburrell commented Sep 6, 2019

Any chance this can get some airtime? Not exactly conforming to HTTP spec. IIS supports these chars. We have a load balancer running inside kestrel and are not exactly in control of response header creation. It's a bit unfortunate to have to alter non-ascii chars.

@dkonyayev
Copy link

We are having issues with this now. Our SSO provider inserts LDAP data into a header, and the LDAP data contains non-ASCII characters that are user's name (ex. Görkem)

It's hard to get resolution on this since only applications on Kestrel are having issues with these headers. All other applications are either processing it successfully or ignoring it.

@Tratcher Tratcher added affected-few This issue impacts only small number of customers severity-major This label is used by an internal tool labels Oct 12, 2020 — with ASP.NET Core Issue Ranking
@davidfowl davidfowl added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Mar 28, 2021
@davidfowl
Copy link
Member

We need an API proposal, this wouldn't be on by default. It's also up for grabs so can be implemented by anyone that needs it once the design and API are approved.

@davidfowl davidfowl added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Mar 29, 2021
@Tratcher
Copy link
Member

We expect this to be a problem for proxy scenarios. Bumping out of backlog for re-triage.

@Tratcher Tratcher removed this from the Backlog milestone May 24, 2021
@BrennanConroy BrennanConroy added this to the 6.0-preview6 milestone May 26, 2021
@Tratcher Tratcher modified the milestones: 6.0-preview6, 6.0-preview7 Jul 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 5, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-few This issue impacts only small number of customers api-suggestion Early API idea and discussion, it is NOT ready for implementation area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-kestrel help wanted Up for grabs. We would accept a PR to help resolve this issue severity-major This label is used by an internal tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants