Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Fix Kestrel host header mismatch handling when port in Url #59403

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[release/8.0] Fix Kestrel host header mismatch handling when port in Url #59403

merged 2 commits into from
Jan 8, 2025
+25 −10

Conversation

BrennanConroy
Copy link
Member

Backport of #59352

Fix Kestrel host header mismatch handling when port in Url

Description

Fixes some validation of host headers in Kestrel if a non-default port is included in the request url.

Customer Impact

Valid requests will result in a 400 error response if they hit this case.
An internal partner team is hitting this currently.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Small bug fix with additional unit test coverage to make sure it works and doesn't regress in the future.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@BrennanConroy BrennanConroy added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Dec 9, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.x milestone Dec 9, 2024
@BrennanConroy BrennanConroy added ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. Servicing-consider Shiproom approval is required for the issue and removed ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Dec 9, 2024
@build-analysis build-analysis bot mentioned this pull request Dec 10, 2024
Open
3 tasks
@BrennanConroy BrennanConroy added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Dec 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 17, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Jan 7, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe
Copy link
Member

wtgodbe commented Jan 8, 2025

Test failure unrelated

@wtgodbe wtgodbe merged commit 1b935dd into release/8.0 Jan 8, 2025
22 of 25 checks passed
@wtgodbe wtgodbe deleted the brecon/bphostheader branch January 8, 2025 00:00
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.13 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
8.0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@BrennanConroy @wtgodbe @adityamandaleeka