Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Markdown alert in Contributing guide #59773

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

martincostello
Copy link
Member

Use Markdown alert

Use GitHub markdown alert.

Description

Use a GitHub native alert to improve the rendering of the note in the contributing guide. I noticed this while watching yesterday's ASP.NET Core Community Standup.

Before

image

After

image

Improve the rendering of the note by using GitHub native markdown alert.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 8, 2025
@martincostello
Copy link
Member Author

There's a bunch more possible candidates in docs/BuildFromSource.md (and probably other places too).

@mkArtakMSFT
Copy link
Member

Looks much cleaner and visually appealing, thanks @martincostello!

@mkArtakMSFT mkArtakMSFT requested a review from Copilot January 10, 2025 18:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@mkArtakMSFT mkArtakMSFT merged commit 8709f36 into dotnet:main Jan 10, 2025
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 10, 2025
@martincostello martincostello deleted the patch-1 branch January 10, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants