Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement HttpRequestStreamReader and HttpResponseStreamWriter with pipes #7836

Open
jkotalik opened this issue Feb 22, 2019 · 1 comment
Labels
affected-few This issue impacts only small number of customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-http-abstractions feature-pipelines Anything relating to exposing/using Pipes in ASP.NET Core severity-minor This label is used by an internal tool
Milestone

Comments

@jkotalik
Copy link
Contributor

jkotalik commented Feb 22, 2019

Epic #8829

Most likely this will be done via two new classes: PipeTextReader and PipeTextWriter. These are implementations of TextReader/TextWriter that take in a PipeReader/PipeWriter as a constructor argument.

@alefranz
Copy link
Contributor

alefranz commented Mar 2, 2020

I've been looking at something to work on and @rynowak has pointed me to this.
I've experimented a bit with this and created a really basic prototype.
If this is still it up for grabs I would like to start to work on a PR.

@JamesNK is this already on your radar as part of #13750?

I was thinking of introducing a HttpResponseStreamWriter that implement TextWriter to handle encoding and write to a pipe.
Does it also needs to be buffered, so to avoid requesting a large buffer (over a configured value) to the underling Pipe and use multiple FlushAsync(), as well as avoiding FlushAsync() for small writes?

Main goal would be to use this from MVC to render the view.

Thank you!

/cc @davidfowl

@pranavkm pranavkm removed the cost: M label Nov 6, 2020
@Tratcher Tratcher added affected-few This issue impacts only small number of customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-minor This label is used by an internal tool labels Nov 11, 2020 — with ASP.NET Core Issue Ranking
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-few This issue impacts only small number of customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-http-abstractions feature-pipelines Anything relating to exposing/using Pipes in ASP.NET Core severity-minor This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

8 participants