-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pipelines-related http features in TestServer #8660
Comments
Something to test/implement with this issue: ensure that |
Bumping out of preview4. I don't think this is a critical thing for preview 4, but feel free to debate :). |
I would like it. Does that make it critical? 🙃 Seriously though, I was looking into grpc/grpc-dotnet#144 yesterday and TestServer never sets Response.HasStarted when the response content is flushed, and that makes our functional tests a little less trustworthy. For example, it is not an error to send headers after writing content. I'm considering moving some of the functional tests to use a spun up Kestrel instance because I don't trust how accurate TestServer is. But I understand there is higher priority work. |
We just don't have the capacity for this in 3.0. I'll put this in preview7 for now, and if someone feels so inspired, we can review a PR :) |
@JamesNK does your PR satisfy this need? Are we ready to close this? |
My PR satisfies my need to have StartAsync work correctly. TestServer still needs to be refactored to use pipes, but from my POV you can bump it to post 3.0 if you don't have time. |
Ok, we'll keep this around. There may be capacity later when the unknown unknowns become known knowns. |
We don't expect to have the capacity in 3.0. Lots on the queue. This is a good candidate for 3.1 though. |
I had a look at this and I believe that most of work has been done as part of #11598. |
Looks like you're correct and #11598 has a better listing of what is done and not yet done. I'm going to close this as a duplicate of it. |
Epic #8829
Split from #7815
We should support the Pipe Goodness on TestServer.
We'd remove the stream-based implementation and use pipes. Stream-based implementation would then be a wrapper around the pipes.
The text was updated successfully, but these errors were encountered: