allow ASCII equality ordinal fast path for en-* cultures (#26905)

* allow ASCII equality ordinal fast path for en-* cultures * dont use StartsWith in the initialization execution path * Update src/System.Private.CoreLib/shared/System/Globalization/CompareInfo.Unix.cs Co-Authored-By: Jan Kotas <[email protected]>
dotnet · Oct 1, 2019 · 87e4971 · 87e4971
1 parent 7fd7985
commit 87e4971
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/System.Private.CoreLib/shared/System/Globalization/CompareInfo.Unix.cs b/src/System.Private.CoreLib/shared/System/Globalization/CompareInfo.Unix.cs
@@ -32,7 +32,12 @@ private void InitSort(CultureInfo culture)
             }
             else
             {
-                _isAsciiEqualityOrdinal = (_sortName == "en-US" || _sortName == "");
+                // Inline the following condition to avoid potential implementation cycles within globalization
+                //
+                // _isAsciiEqualityOrdinal = _sortName == "" || _sortName == "en" || _sortName.StartsWith("en-", StringComparison.Ordinal);
+                //
+                _isAsciiEqualityOrdinal = _sortName.Length == 0 ||
+                    (_sortName.Length >= 2 && _sortName[0] == 'e' && _sortName[1] == 'n' && (_sortName.Length == 2 || _sortName[2] == '-'));
 
                 _sortHandle = SortHandleCache.GetCachedSortHandle(_sortName);
             }