Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize native code size of Dictionary methods #7858

Closed
jkotas opened this issue Apr 11, 2017 · 4 comments
Closed

Optimize native code size of Dictionary methods #7858

jkotas opened this issue Apr 11, 2017 · 4 comments
Assignees
Labels
help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue

Comments

@jkotas
Copy link
Member

jkotas commented Apr 11, 2017

From dotnet/coreclr#10203 (comment)

I have glanced over the native code generated for Dictionary<int,int>.Remove. The CSE for entry[i] kicks in some cases, but not others. If you cache ref Entry entry = ref entries[i]; at the start of the loop and replace all 9 occurrences of entries[i] with it, the native code generated for this method should be approximately 20% smaller.

@omariom
Copy link
Contributor

omariom commented Apr 11, 2017

We can already use C# 7 in coreclr and corefx!?

@jkotas
Copy link
Member Author

jkotas commented Apr 11, 2017

Yes, for a while already.

@mikedn
Copy link
Contributor

mikedn commented Apr 12, 2017

You can assign to me

@jkotas
Copy link
Member Author

jkotas commented Apr 12, 2017

@mikedn Thank you!

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

3 participants