From 3922d7214787e63f54f31b7b360ece0e3b686adf Mon Sep 17 00:00:00 2001 From: Jonghyun Park Date: Fri, 2 Dec 2016 16:26:04 +0900 Subject: [PATCH 1/2] [x86/Linux] Fix unused function warning --- src/vm/i386/excepx86.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vm/i386/excepx86.cpp b/src/vm/i386/excepx86.cpp index 5ee49ff2eddb..9512197eeabc 100644 --- a/src/vm/i386/excepx86.cpp +++ b/src/vm/i386/excepx86.cpp @@ -431,6 +431,7 @@ CPFH_AdjustContextForThreadSuspensionRace(CONTEXT *pContext, Thread *pThread) #endif // FEATURE_HIJACK +#if 0 // We want to leave true null reference exceptions alone. But if we are // trashing memory, we don't want the application to swallow it. The 0x100 // below will give us false positives for debugging, if the app is accessing @@ -443,6 +444,7 @@ CPFH_ShouldIgnoreException(EXCEPTION_RECORD *pExceptionRecord) { LIMITED_METHOD_CONTRACT; return FALSE; } +#endif static inline void CPFH_UpdatePerformanceCounters() { From 7b43c2bc975470a6318d46db127b1012b7ea924c Mon Sep 17 00:00:00 2001 From: Jonghyun Park Date: Mon, 5 Dec 2016 08:24:58 +0900 Subject: [PATCH 2/2] Delete the unused code --- src/vm/i386/excepx86.cpp | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/vm/i386/excepx86.cpp b/src/vm/i386/excepx86.cpp index 9512197eeabc..def490d6e00d 100644 --- a/src/vm/i386/excepx86.cpp +++ b/src/vm/i386/excepx86.cpp @@ -431,20 +431,6 @@ CPFH_AdjustContextForThreadSuspensionRace(CONTEXT *pContext, Thread *pThread) #endif // FEATURE_HIJACK -#if 0 -// We want to leave true null reference exceptions alone. But if we are -// trashing memory, we don't want the application to swallow it. The 0x100 -// below will give us false positives for debugging, if the app is accessing -// a field more than 256 bytes down an object, where the reference is null. -// -// Removed use of the IgnoreUnmanagedExceptions reg key...simply return false now. -// -static inline BOOL -CPFH_ShouldIgnoreException(EXCEPTION_RECORD *pExceptionRecord) { - LIMITED_METHOD_CONTRACT; - return FALSE; -} -#endif static inline void CPFH_UpdatePerformanceCounters() {