Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span: Fix array variance checks in slow Span #19693

Closed
ahsonkhan opened this issue Dec 15, 2016 · 6 comments
Closed

Span: Fix array variance checks in slow Span #19693

ahsonkhan opened this issue Dec 15, 2016 · 6 comments
Assignees
@shiftylogic
Labels
area-System.Memory bug good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Milestone
2.0.0

Comments

@ahsonkhan
Copy link
Member

Related to PR dotnet/corefx#14262 where the test got removed.

  • The test should be renamed to something like CtorVariantArrayType since the type is not wrong.
  • The test should confirm that the operation is succeeding, i.e. a ReadOnlySpan instance gets created successfully rather than checking that the method fails and throws.

dotnet/corefx#14262 (comment)
@jkotas
Copy link
Member

jkotas commented Dec 15, 2016

Also, fix the implementation of the slow span to not throw exception in this case...

@karelz karelz changed the title Rewrite the ReadOnlySpan/CtorArray CtrArrayWrongArrayType test Span: Rewrite the ReadOnlySpan/CtorArray CtrArrayWrongArrayType test Dec 15, 2016
@karelz
Copy link
Member

karelz commented Mar 2, 2017

Next step: Do the work highlighted in the top post by @ahsonkhan .
Should be simple (1h work).

@jkotas jkotas changed the title Span: Rewrite the ReadOnlySpan/CtorArray CtrArrayWrongArrayType test Span: Fix array variance checks in slow Span Mar 14, 2017
@jkotas
Copy link
Member

jkotas commented Mar 14, 2017 •
edited
Loading

This is not just a test issue. The primary issue here is that the array variance checks are done incorrectly in the slow ReadOnlySpan.

@karelz
Copy link
Member

karelz commented Mar 14, 2017

How complex is it to fix? Is it good candidate for up-for-grabs?

@jkotas
Copy link
Member

jkotas commented Mar 14, 2017 •
edited
Loading

It is not complex, but requires understanding of array variance.

@shiftylogic shiftylogic self-assigned this Mar 21, 2017
@shiftylogic
Copy link
Contributor

PR Submitted (#17361)

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shiftylogic shiftylogic

Labels
area-System.Memory bug good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
5 participants
@karelz @ahsonkhan @jkotas @msftgits @shiftylogic