Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to increase code coverage for Span<T> APIs #20608

Closed
ahsonkhan opened this issue Mar 14, 2017 · 5 comments · Fixed by dotnet/corefx#17472
Closed

Add tests to increase code coverage for Span<T> APIs #20608

ahsonkhan opened this issue Mar 14, 2017 · 5 comments · Fixed by dotnet/corefx#17472
Labels
area-System.Memory help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Milestone

Comments

@ahsonkhan
Copy link
Member

Here is a snapshot of the coverage:
image

Currently, SpanHelpers, specifically SpanHelpers.Clear.cs needs tests.
https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Memory_SpanHelpers.htm

@ahsonkhan
Copy link
Member Author

@shiftylogic
Copy link
Contributor

Until yesterday, I'm pretty sure those tests were never running against slow Span. I added netfx to the test configuration, but we might need to add more.

@shiftylogic
Copy link
Contributor

shiftylogic commented Mar 23, 2017

FYI, if you run code coverage locally against System.Memory using the netfx framework, the numbers look much better.

image

Locally (not netfx):
image

@ahsonkhan
Copy link
Member Author

Code Coverage

SlowSpan:
image

FastSpan:
image

@ahsonkhan
Copy link
Member Author

System.Private.Corelib Code Coverage (for Span):
image
image

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Memory help wanted [up-for-grabs] Good issue for external contributors test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants