Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in CoreFx packages due to net461 > ns2.0 mapping #21409

Closed
ericstj opened this issue Apr 27, 2017 · 4 comments
Closed

Breaking changes in CoreFx packages due to net461 > ns2.0 mapping #21409

ericstj opened this issue Apr 27, 2017 · 4 comments
Assignees
Labels
area-Infrastructure-libraries documentation Documentation bug or enhancement, does not impact product or test code
Milestone

Comments

@ericstj
Copy link
Member

ericstj commented Apr 27, 2017

The remapping can cause ref-def mismatches when a NS1.5 or higher library is consumed in net461. For example see aspnet/MusicStore#775 (comment).

We could mitigate this by shoving those into the NETStandard.Library.NETFramework package, effectively "lifting" the implementation assembly up to the higher version via conflict resolution.

Alternatively we do nothing and document that folks should upgrade those packages.

@weshaggard @terrajobst, thoughts?

@weshaggard
Copy link
Member

I would prefer we keep the support package just to things that are not inbox. For these I think the fall into the same bucket as SqlClient that folks have to update their reference to those packages.

@ericstj
Copy link
Member Author

ericstj commented Apr 28, 2017

We should probably collect a list of all impacted packages and write up a release note for it.

@karelz
Copy link
Member

karelz commented Sep 4, 2018

@ericstj do we still have some work left here? It is old bug with 2.0.0 milestone.

@ericstj
Copy link
Member Author

ericstj commented Sep 10, 2018

Yes this should be closed. The SDK actually did the work of fixing this by forcing folks up to the latest facades when it found they were in this spot.

@ericstj ericstj closed this as completed Sep 10, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

No branches or pull requests

4 participants