Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run Debug corefx official builds and tests runs weekly #24194

Closed
weshaggard opened this issue Nov 20, 2017 · 16 comments
Closed

Only run Debug corefx official builds and tests runs weekly #24194

weshaggard opened this issue Nov 20, 2017 · 16 comments
Assignees
Milestone

Comments

@weshaggard
Copy link
Member

We don't need to do official builds for both release and debug multiple times daily. Our general official builds should be defaulted to Release but we should enable a weekly Debug build for extra test validation.

@danmosemsft any preference on which day of the week so you can pay extra attention to the test results?

@weshaggard weshaggard self-assigned this Nov 20, 2017
@stephentoub
Copy link
Member

any preference on which day of the week so you can pay extra attention to the test results?

Maybe Sunday night?

@weshaggard
Copy link
Member Author

weshaggard commented Jan 3, 2018

We can't do this automatically without https://github.com/dotnet/core-eng/issues/2176.
For 2.1 we will have to manually queue builds periodically.

@weshaggard
Copy link
Member Author

For 2.1 here is a manual 2.1 Debug build:
https://mc.dot.net/#/product/netcore/master/source/official~2Fcorefx~2Fmaster~2F/type/test~2Ffunctional~2Fcli~2F/build/20180314.07

For comparision here is the Release build test results:
https://mc.dot.net/#/product/netcore/master/source/official~2Fcorefx~2Fmaster~2F/type/test~2Ffunctional~2Fcli~2F/build/20180314.06

@danmosemsft could you please as someone to compare the results to ensure we don't have any meaningful differences?

@danmoseley
Copy link
Member

I went through them and nothing looks chk specific., I made sure there were issues for everything.

Can you set this up to run weekly now?

@danmoseley
Copy link
Member

And if you do, how will we avoid missing them in all the release builds?

@weshaggard
Copy link
Member Author

weshaggard commented Mar 15, 2018

Can you set this up to run weekly now?

Not yet we are still dependent on dotnet/core-eng#2176 which isn't funded.

@weshaggard weshaggard removed their assignment Nov 5, 2018
@ViktorHofer
Copy link
Member

This can probably be done after migration to Azure DevOps is done. @safern I'll assign you, I hope that's fine.

@ViktorHofer
Copy link
Member

Do we still want that? The additional legs in official builds aren't much to pay, I wouldn't remove the Debug legs unless there's a strong reason to do so.

@danmoseley
Copy link
Member

@ViktorHofer I have no opinion. If they are not distracting and we aren't asked to free machines I guess it should be OK to keep them.

@ViktorHofer
Copy link
Member

OK great, let's close this until somebody asks.

@safern
Copy link
Member

safern commented Mar 4, 2019

I wouldn't remove the Debug legs unless there's a strong reason to do so.

You can't remove them, because there are no Debug legs now in official builds 😄 -- I think this issue is to add 1 weekly run for Debug builds of our official matrix.

@danmoseley
Copy link
Member

Oh! We should certainly have regular runs at some frequency.

@ViktorHofer ViktorHofer reopened this Mar 4, 2019
@ViktorHofer
Copy link
Member

Ok 😀

@safern
Copy link
Member

safern commented Mar 4, 2019

I think to do this periodically we would need to create a new build def and do some plumbing on the yml files. Shouldn't take long, but don't have bandwidth now, I'll probably work on it in 5 weeks or so 😄

@ViktorHofer
Copy link
Member

Closing as we just restructured our test matrix and don't run tests anymore in official builds. I believe disabling additional configurations isn't necessary anymore as we already saved resources.

@ViktorHofer
Copy link
Member

(feel free to reopen if you disagree)

@ViktorHofer ViktorHofer reopened this May 20, 2019
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants