-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run Debug corefx official builds and tests runs weekly #24194
Comments
Maybe Sunday night? |
We can't do this automatically without https://github.com/dotnet/core-eng/issues/2176. |
For 2.1 here is a manual 2.1 Debug build: For comparision here is the Release build test results: @danmosemsft could you please as someone to compare the results to ensure we don't have any meaningful differences? |
I went through them and nothing looks chk specific., I made sure there were issues for everything. Can you set this up to run weekly now? |
And if you do, how will we avoid missing them in all the release builds? |
Not yet we are still dependent on dotnet/core-eng#2176 which isn't funded. |
This can probably be done after migration to Azure DevOps is done. @safern I'll assign you, I hope that's fine. |
Do we still want that? The additional legs in official builds aren't much to pay, I wouldn't remove the Debug legs unless there's a strong reason to do so. |
@ViktorHofer I have no opinion. If they are not distracting and we aren't asked to free machines I guess it should be OK to keep them. |
OK great, let's close this until somebody asks. |
You can't remove them, because there are no Debug legs now in official builds 😄 -- I think this issue is to add 1 weekly run for Debug builds of our official matrix. |
Oh! We should certainly have regular runs at some frequency. |
Ok 😀 |
I think to do this periodically we would need to create a new build def and do some plumbing on the yml files. Shouldn't take long, but don't have bandwidth now, I'll probably work on it in 5 weeks or so 😄 |
Closing as we just restructured our test matrix and don't run tests anymore in official builds. I believe disabling additional configurations isn't necessary anymore as we already saved resources. |
(feel free to reopen if you disagree) |
We don't need to do official builds for both release and debug multiple times daily. Our general official builds should be defaulted to Release but we should enable a weekly Debug build for extra test validation.
@danmosemsft any preference on which day of the week so you can pay extra attention to the test results?
The text was updated successfully, but these errors were encountered: