Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stress tests for Span<T> APIs #25524

Closed
ahsonkhan opened this issue Mar 19, 2018 · 2 comments
Closed

Add stress tests for Span<T> APIs #25524

ahsonkhan opened this issue Mar 19, 2018 · 2 comments
Labels
area-System.Memory test-enhancement Improvements of test source code
Milestone

Comments

@ahsonkhan
Copy link
Member

From dotnet/corefxlab#1313

  • Tests with multiple threads to confirm that Span APIs are stateless and thread safe
  • Tests with lots of GC allocations to confirm that when GC moves addresses around, the use of Span is still correct
@jkotas
Copy link
Member

jkotas commented Mar 20, 2018

You should just make sure that this is covered by the existing stress mixes run by the stress team (cc @valenis). There is no point in you building a separate stress harness for Span.

@bartonjs
Copy link
Member

bartonjs commented Mar 28, 2018

What I understand from @DrewScoggins is that the stress mixes will run [Fact] tests (but not, currently, [Theory] tests).

Span currently has many (~500) [Fact] tests and ~10 [Theory] methods (which are mostly on AsSpan), based on src\System.Memory\tests\Span\* as of 821f44ea4650f178f9ada3d85e54b1088a27e14d.

So I think we're in good shape.

@bartonjs bartonjs removed their assignment Nov 23, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Memory test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

4 participants