-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dotnet-counters help text for .NET 5 #1188
Comments
Are there rules for what counters we add to this list? Because there are a lot more that aren't mentioned. |
Things that ship in the "shared framework" are considered part of "known counters". That would include .NET runtime (Microsoft.NETCore.App package) and ASP.NET Core. @noahfalk Can you clarify this? |
We didn't have any formalized rules on this, I think the ad-hoc criteria is: In the future I hope to have something that automatically enumerates counters in a process, but for now we've been doing it on the cheap. Thanks for the heads up about the new counters! |
@sywhang Is there a good place where I can find the entire list of counters which meet the criteria Noah listed above? I am trying to document ApplicationInsights EventCounter doc, to add a link to the list of "known counters". |
There isn't a place with docs on these counters other than just the dotnet-counters tool itself. So for now, I think the best place to find them is using the |
ASP.NET Core has added new counters for .NET 5. PR: dotnet/aspnetcore#21649
.NET runtime stack (System.Net.* components) will be adding new counters shortly as well.
The help text in KnownData.cs needs to be updated with these new counters.
The text was updated successfully, but these errors were encountered: