Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is >= necessary when building .NET Core for distribution to allow upgrades? #15947

Closed
dagood opened this issue Nov 22, 2019 · 2 comments
Closed
Labels
won't fix Issues that were closed as part of automated backlog grooming

Comments

@dagood
Copy link
Member

dagood commented Nov 22, 2019

Dependencies between packages should use an equal or greater than version requirement. For example, dotnet-sdk-2.2:2.2.401 requires aspnetcore-runtime-2.2 >= 2.2.6. This makes it possible for the user to upgrade their installation via a root package (for example, dnf update dotnet-sdk-2.2).

Why does a >= dependency "make it possible" for a user to upgrade? What is it contrasting against that doesn't allow the user to upgrade their installation via dnf update etc.?

For example, does the following block upgrade from 3.0.0 to 3.0.1 somehow?

  • dotnet-sdk-3.0 3.0.0 requires dotnet-targeting-pack-3.0 = 3.0.0
  • dotnet-sdk-3.0 3.0.1 requires dotnet-targeting-pack-3.0 = 3.0.1

This more accurately represents the actual dependency (more info at dotnet/installer#5738).

/cc @leecow @tmds @omajid @nguerrera @dleeapho


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@tmds
Copy link
Member

tmds commented Nov 22, 2019

This makes it possible for the user to upgrade their installation via a root package

This is about expressing a dependency on a version vs not specify a version.
When not specifying a version, updating dotnet-sdk package won't update dotnet-runtime for example.

On the difference between >= and =, this is about whether dependencies are backwards compatible, and if they may be updated to a later version without updating the dependent.
If there is no backwards compatibility, = should be used.

@dotnet-bot
Copy link
Contributor

This issue has been closed as part of the issue backlog grooming process outlined in #22351.

That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why. Tag the @dotnet/docs team for visibility.

@dotnet-bot dotnet-bot added the won't fix Issues that were closed as part of automated backlog grooming label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix Issues that were closed as part of automated backlog grooming
Projects
None yet
Development

No branches or pull requests

7 participants