Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet.config of MakeConst sample can be deleted #24545

Closed
Youssef1313 opened this issue Jun 7, 2021 · 3 comments · Fixed by #24555 or dotnet/samples#4643
Closed

NuGet.config of MakeConst sample can be deleted #24545

Youssef1313 opened this issue Jun 7, 2021 · 3 comments · Fixed by #24555 or dotnet/samples#4643
Assignees

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jun 7, 2021

It existed there before the testing library was published to NuGet.org. I believe it can be safely deleted now.

https://github.com/dotnet/docs/blob/main/docs/csharp/roslyn-sdk/tutorials/snippets/how-to-write-csharp-analyzer-code-fix/NuGet.config

Parallel PR should be made in dotnet/samples

This also requires updating the testing package version. The version should match the updated template, see dotnet/roslyn-sdk#855.

@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jun 7, 2021
@PRMerger9 PRMerger9 added the Pri3 label Jun 7, 2021
@Youssef1313
Copy link
Member Author

@gewarren IIRC, there was some security warning for the NuGet.config that you suppressed or something like that. It can be re-enabled once this is fixed.

@BillWagner
Copy link
Member

Thanks for noting this @Youssef1313

Do you want to submit a PR for this? If so, I'll assign it to you.

Otherwise, I'll take care of it later this week.

@Youssef1313
Copy link
Member Author

Thanks for pinging @BillWagner. Opening a PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants