Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonDocument is not thread safe #31508

Merged
merged 2 commits into from
Sep 30, 2022
Merged

JsonDocument is not thread safe #31508

merged 2 commits into from
Sep 30, 2022

Conversation

gewarren
Copy link
Contributor

Fixes #20563.

@dotnet-bot dotnet-bot added this to the September 2022 milestone Sep 30, 2022
@gewarren gewarren requested review from eiriktsarpalis and a team September 30, 2022 16:52
IEvangelist
IEvangelist approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@eiriktsarpalis
Copy link
Member

eiriktsarpalis commented Sep 30, 2022 •
edited
Loading

FWIW there is an open PR in runtime that tries to fix thread safety for JsonDocument: dotnet/runtime#76450 but that's a .NET 8 change.

@gewarren gewarren enabled auto-merge (squash) September 30, 2022 22:39
@gewarren gewarren merged commit 4d206c5 into dotnet:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

Please add documentation for thread-safety guarantees of JsonDocument (and related types)
4 participants
@gewarren @eiriktsarpalis @IEvangelist @dotnet-bot