Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop generating dynamic method for each query invocation #31783

Closed
roji opened this issue Sep 18, 2023 · 2 comments
Closed

Stop generating dynamic method for each query invocation #31783

roji opened this issue Sep 18, 2023 · 2 comments

Comments

@roji
Copy link
Member

roji commented Sep 18, 2023

In ParameterExtractingExpressionVisitor, we identify fragments of the query tree which aren't server correlated, compile them into a method and invoke that method to client-evaluate that part of the tree (the results are then embedded back as a parameter). In #29815 (merged for 8.0), we switched to use interpretation instead of compilation, but in all other versions the continuous compilation can creates considerable amounts of load, with a customer report of the finalizer thread getting backed up and the server needing to be eventually killed.

We should backport specifically the ParameterExtractingExpressionVisitor change to 7.0 and 6.0.

@roji
Copy link
Member Author

roji commented Sep 18, 2023

Actually, closing - #31782 can track this.

@roji roji closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
@roji
Copy link
Member Author

roji commented Sep 18, 2023

Duplicate of #31782

@roji roji marked this as a duplicate of #31782 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant