Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UpdateXlf task work on Mono #4667

Closed
jwosty opened this issue Apr 3, 2018 · 4 comments
Closed

Make UpdateXlf task work on Mono #4667

jwosty opened this issue Apr 3, 2018 · 4 comments

Comments

@jwosty
Copy link
Contributor

jwosty commented Apr 3, 2018

We should be able to perform some localization tasks on Mono, specifically /t:UpdateXlf on FSharp.Compiler.Private.fsproj. Not being able to do so is a huge hindrance to my (and presumably others') contributions; currently the process looks like:

  1. Make change, push to PR branch.
  2. Wait ~45min or an hour for CI build to finish. If success, we're done.
  3. Mess with the resource files manually, push back to PR.
  4. If I don't know what the problem is and/or I can't figure out how to fix it myself, bug someone else (with Windows) to do UpdateXlf. Either way, goto step 2.

This also just ends up creating a bunch of cluttersome, half-baked commits that shouldn't have to be pushed to CI one by one just to see what they break. (I know they're all squashed, by still, trying to read the resulting squash merge message would be awful -- mostly "Fix CI" or "Fix xlf" kind of thing).

For reference, Localization (XLF) task imports are prevented on Mono in FSharp.Source.Settings.Target (L126).

@jwosty
Copy link
Contributor Author

jwosty commented Apr 3, 2018

@brettfo (conversation in PR 4427):

Ahh, good find. On non-Windows machines the $(MonoPackaging) variable is getting set to true which in turn sets $(DisableLocalization) to true which prevents the import of XliffTasks.targets.

@dsyme added the $(MonoPackaging)=true -> $(DisableLocalization) stuff so I'll ask him if he remembers why localization support was disabled on non-Windows, but I suspect it's because localization requires al.exe which is Windows only.

...

@dsyme (conversation in PR 4427):

It's only because I and other contributors to the Mono packaging like @directhex, @nosami and @knocte have little idea how localization works, and no real capacity to adjust packaging and investigate issues.

@directhex
Copy link
Contributor

I'm happy to make changes to packaging, I just have no idea what needs changing where.

@cartermp
Copy link
Contributor

cartermp commented Apr 3, 2018

@directhex - @brettfo and @mmitche may be able to help with that.

@brettfo
Copy link
Member

brettfo commented Mar 25, 2020

Build is now SDK-based, so Mono build isn't a thing.

@brettfo brettfo closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants