ship Portable PDB files instead for FSharp.Core

[ctaggart]

Following up on #294, please ship the Portable PDB files for FSharp.Core.

Using JetBrains dotPeek > Tools > Show PDB Content...
it shows the PdbType="Windows":

<?xml version="1.0" encoding="utf-8"?>
<Pdb Name="FSharp.Core" Path="C:\Users\taggac\AppData\Local\Temp\SymbolCache\FSharp.Core.pdb\0A868D34CF4743D0B21CC9DF656936A71\FSharp.Core.pdb" AssemblyPath="C:\Users\taggac\AppData\Local\Temp\SymbolCache\FSharp.Core.pdb\0A868D34CF4743D0B21CC9DF656936A71\FSharp.Core.dll" PdbType="Windows" Signature="0a868d34-cf47-43d0-b21c-c9df656936a7" Age="1" AgeOrTimestampFromAssembly="" SignatureFromAssembly="" PdbFileFromAssembly="">
  <UserEntryPoint>null</UserEntryPoint>
  <ImportScope Index="1" Parent="null" />
</Pdb>

[baronfel]

From what I can see this is entirely controlled by the setting set in FSharpBuild.Directory.Build.props, where it's set to embedded:

fsharp/FSharpBuild.Directory.Build.props

Line 91 in 2e41de6

<DebugType>embedded</DebugType>

Is this the only thing that would need to change?

[KevinRansom]

This has been fixed.

We have shipped embedded portable pdbs in FSharp.Core since 4.7.0. released on 8/2/2019
The debug directory of FSharp.Core

net45\FSharp.Core.dll

Debug Directory:
  CodeView stamp=0xAF8380A7, version=(0x0100, 0x504D), size=40
    path='FSharp.Core.pdb', guid={6c755dd3-d379-4fa3-9157-1761ae9ac195}, age=1
  PdbChecksum stamp=0xAF8380A7, version=(0x0001, 0x0100), size=39
  EmbeddedPortablePdb stamp=0x00000000, version=(0x0100, 0x0100), size=136855
  Reproducible stamp=0x00000000, version=(0x0000, 0x0000), size=0

netstandard2.0\FSharp.Core.dll

Debug Directory:
  CodeView stamp=0xC04F0035, version=(0x0100, 0x504D), size=40
    path='FSharp.Core.pdb', guid={7480aa60-32a8-4af9-a4f9-94c11eeb3d50}, age=1
  PdbChecksum stamp=0xC04F0035, version=(0x0001, 0x0100), size=39
  EmbeddedPortablePdb stamp=0x00000000, version=(0x0100, 0x0100), size=136993
  Reproducible stamp=0x00000000, version=(0x0000, 0x0000), size=0