Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support portable pdb files #718

Closed
ctaggart opened this issue Nov 9, 2015 · 7 comments
Closed

support portable pdb files #718

ctaggart opened this issue Nov 9, 2015 · 7 comments

Comments

@ctaggart
Copy link
Contributor

ctaggart commented Nov 9, 2015

Portable pdb files are designed specifically for .NET. The spec is now 1.0 and an implementation ships with Roslyn for Visual Studio 2015 Update 1. The new format is cross platform and several times smaller, making it practical to include in the nupkgs #294. This should take care of the CoreCLR status issue of Enable CoreCLR debugging of F#.

Microsoft.DiaSymReader.PortablePdb exists to provide compatibility to the existing Windows debugging tools that build on top of that COM API.
image

I am advocating that the old PDB support be dropped to makes things simpler and easier to maintain.

@enricosada
Copy link
Contributor

No need to deprecate pdb, just add the portable pdb, the user can choose using a compiler flag.
After portable pdb works, can be the default for new projects ( in project templates )

Btw yes, i think portable pdb is not a coreclr only issue, should be send to master, and merged in coreclr later, so we can use it with desktop clr ( .net 4.0 )

@dsyme dsyme changed the title switch to portable pdb files support portable pdb files Nov 10, 2015
@Alxandr
Copy link

Alxandr commented Nov 13, 2015

I agree with @ctaggart that the old PDBs should be deprecated/dropped.

@dsyme
Copy link
Contributor

dsyme commented Nov 14, 2015

I expect we won't drop for a while, as the compiler will still need to be used for .NET Framework compilation on back-target .NET implementations (4.0-4.6) for several years to come. There may be a "compat" compiler that is used to achieve this.

But getting the new format implemented would be wonderful.

@ctaggart
Copy link
Contributor Author

I don't think the new pdb format is tied to a .NET Framework version. There is a Microsoft.DiaSymReader.PortablePdb that is being worked on to allow existing Windows debuggers to work with the new format. It would be good to define the test cases for switching.

@KevinRansom
Copy link
Member

Portable pubs will be generated by the coreclr version of the compiler. It is the next but one thing on my list.

@ctaggart
Copy link
Contributor Author

Awesome! Looking forward to it. I am going to try to get SourceLink working with them this month.

@dsyme
Copy link
Contributor

dsyme commented Jul 18, 2016

This has been implemented

@dsyme dsyme closed this as completed Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants