From d3c08ff9f3ea53f51f48a5426926c10720b9b0eb Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Wed, 2 Aug 2023 15:50:49 +0200 Subject: [PATCH] [tools] Always link weakly with NewsstandKit. Fixes #18606. It seems that Apple will completely remove the NewsstandKit framework from iOS 17. This poses a problem for existing apps that link with NewsstandKit: they will crash at launch. Solve this by always linking weakly with the NewsstandKit framework; this way any apps that link with it will keep working if the framework ends up being removed by Apple. Fixes https://github.com/xamarin/xamarin-macios/issues/18606. --- tools/common/Frameworks.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/common/Frameworks.cs b/tools/common/Frameworks.cs index b73f53206883..b38fb599ccab 100644 --- a/tools/common/Frameworks.cs +++ b/tools/common/Frameworks.cs @@ -341,7 +341,7 @@ public static Frameworks CreateiOSFrameworks (bool is_simulator_build) { "Accounts", "Accounts", 5 }, { "GLKit", "GLKit", 5 }, - { "NewsstandKit", "NewsstandKit", 5 }, + { "NewsstandKit", "NewsstandKit", 5, /* alwaysWeakLink: */ true }, // This framework was completely removed in iOS 17, so make sure existing apps that may link with NewsstandKit don't crash (by linking weakly). Ref: https://github.com/xamarin/xamarin-macios/issues/18606 { "CoreImage", "CoreImage", 5 }, { "CoreBluetooth", "CoreBluetooth", 5 }, { "Twitter", "Twitter", 5 },