Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adding of "rare events" #11315

Open
JanKrivanek opened this issue Jan 20, 2025 · 0 comments
Open

Enable adding of "rare events" #11315

JanKrivanek opened this issue Jan 20, 2025 · 0 comments
Labels
Area: Telemetry Candidates benefiting from telemtry data needs-design Requires discussion with the dev team before attempting a fix. triaged

Comments

@JanKrivanek
Copy link
Member

Context

We might want to collect info about 'black swan' patterns we understand as very rare and we might be deciding specific changes based on assumed usage of those. Collecting such events with higher sample rate (up to 1) might be helpful to contradict our theories (it might not be used as clear confirmation though - as there might be usages with opted-out telemetry collection).

Suggestion

We should thing about adding internal API that would allow collection of such events from within main or worker nodes without much boilerplate code.
Something along the lines of:

void MSBuildTelemetry.AddEvent(string key, string value, bool needsHashing = true, double samplingRate = 1.0);

The infra would then take care about transfering the event and attaching to the Activity (and overriding the default activity sampling if needed).

The proper design is however needed for this.

@JanKrivanek JanKrivanek added Area: Telemetry Candidates benefiting from telemtry data needs-design Requires discussion with the dev team before attempting a fix. labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Telemetry Candidates benefiting from telemtry data needs-design Requires discussion with the dev team before attempting a fix. triaged
Projects
None yet
Development

No branches or pull requests

2 participants