Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSBuild is boxing 25 MB worth of ImmutableList<T>/List<T> enumerators #2265

Closed
davkean opened this issue Jul 6, 2017 · 1 comment
Closed

MSBuild is boxing 25 MB worth of ImmutableList<T>/List<T> enumerators #2265

davkean opened this issue Jul 6, 2017 · 1 comment
Labels
performance Performance-Scenario-References This issue affects adding/removing/editing references Priority:2 Work that is important, but not critical for the release triaged

Comments

@davkean
Copy link
Member

davkean commented Jul 6, 2017 •
edited
Loading

Looking at trace from @jainaashish, I noticed that MSBuild is boxing 25 MB (0.6% of the entire scenario - which was installing a bunch of NuGet pages) worth of enumerators:

image

See: \scratch2\scratch\asja\AddReference Perf ETL logs

These are struct enumerators - so they are probably being passed as IEnumerable<string> somewhere.
@davkean davkean mentioned this issue Jul 6, 2017
Closed
@rainersigwald rainersigwald added this to the MSBuild 15 "foundation update" 2 milestone Jul 6, 2017
@jainaashish jainaashish mentioned this issue Jul 6, 2017
Closed
@davkean davkean mentioned this issue Oct 2, 2017
Closed
@panopticoncentral panopticoncentral added the Performance-Scenario-References This issue affects adding/removing/editing references label Mar 25, 2020
@panopticoncentral panopticoncentral removed this from the MSBuild 15.6 milestone May 21, 2020
@panopticoncentral panopticoncentral added the Priority:2 Work that is important, but not critical for the release label Mar 23, 2021
@ladipro
Copy link
Member

ladipro commented Apr 13, 2021

@ladipro ladipro closed this as completed Apr 13, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Performance-Scenario-References This issue affects adding/removing/editing references Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@panopticoncentral @davkean @rainersigwald @AndyGerlicher @ladipro @AR-May