Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSBuild Server] Define and handle build request message #6425

Closed
rokonec opened this issue May 7, 2021 · 1 comment
Closed

[MSBuild Server] Define and handle build request message #6425

rokonec opened this issue May 7, 2021 · 1 comment
Assignees
Labels
performance Performance-Scenario-Build This issue affects build performance. triaged
Milestone

Comments

@rokonec
Copy link
Member

rokonec commented May 7, 2021

Using existing infrastructure code, define and handle message (INodePacket) for MSBuild Server request.

Work breakdown:

  • define message format: (header(type, len), string(workingDirectory), string(command line)
  • handle 'MSBuild Server request' message by calling MSBuild entry point
  • use named mutex to guarantee build exclusivity (no concurrent builds are allowed)
  • if build is already running reply with message MSBuildServerBusy - that will be handled by caller by fallbacking to standard non-server entry point (running new MSBuild process, loading MSBuild.dll into CLI and start it, ...)
  • after build is finished reply with message MSBuildServerDone containing same exit code as would MSBuild process returned
  • introduce ETL events to trace and measure perf of above
@rokonec rokonec added the needs-triage Have yet to determine what bucket this goes in. label May 7, 2021
@rokonec rokonec self-assigned this May 7, 2021
@rokonec rokonec added Performance-Scenario-Build This issue affects build performance. performance and removed needs-triage Have yet to determine what bucket this goes in. labels May 7, 2021
@rokonec rokonec mentioned this issue May 7, 2021
7 tasks
@rokonec
Copy link
Member Author

rokonec commented Jun 21, 2021

Implemented and parked into https://github.com/dotnet/msbuild/tree/feature/msbuild-server-v2--parked

Work left:

  • unit tests
  • refactoring and cleaning

@rokonec rokonec closed this as completed Jun 21, 2021
@ladipro ladipro added this to the VS 17.0 milestone Dec 8, 2021
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance-Scenario-Build This issue affects build performance. triaged
Projects
None yet
Development

No branches or pull requests

3 participants