Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Built-in analyzer] Build depends on an environment variable #9885

Closed
Tracked by #9630 ...
ladipro opened this issue Mar 18, 2024 · 1 comment · Fixed by #10307
Closed
Tracked by #9630 ...

[Built-in analyzer] Build depends on an environment variable #9885

ladipro opened this issue Mar 18, 2024 · 1 comment · Fixed by #10307
Assignees
Labels
Area: BuildCheck BuildCheck Suggestion Suggestion for a built in MSBuild analyzer. Label should be applied together with 'Area: BuildCheck' triaged

Comments

@ladipro
Copy link
Member

ladipro commented Mar 18, 2024

Background

This issue tracks one of the BuildCheck analyzers we would like to ship in-box with MSBuild.

Goal

Implement an analyzer with the following rule: No implicit property derived from an environment variable is used during the build.

Notes

Depending on the environment leads to build reproducibility problems. Properties should instead be passed to MSBuild explicitly on the command line with /p.

@sharwell
Copy link
Member

Related to #2713

@YuliiaKovalova YuliiaKovalova self-assigned this May 2, 2024
@baronfel baronfel added the BuildCheck Suggestion Suggestion for a built in MSBuild analyzer. Label should be applied together with 'Area: BuildCheck' label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BuildCheck BuildCheck Suggestion Suggestion for a built in MSBuild analyzer. Label should be applied together with 'Area: BuildCheck' triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants