You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently both Orleans & Kestrel register an implementation for IConnectionListenerFactory. Both have different requirements of the created ConnectionContexts, however and so when they are both configured on the same IHostBuilder/container we can observe NullReferenceExceptions from ASP.NET. Registering them in the reverse order would likely cause similar issues in Orleans.
We can change our registration to disambiguate it from Kestrel's, but issues may occur with other users of these abstractions. I imagine the problem would also exist with IConnectionFactory (eg, maybe Orleans + SignalR).
This is specific to Orleans 3.0-rc1.
Currently both Orleans & Kestrel register an implementation for
IConnectionListenerFactory
. Both have different requirements of the created ConnectionContexts, however and so when they are both configured on the sameIHostBuilder
/container we can observeNullReferenceException
s from ASP.NET. Registering them in the reverse order would likely cause similar issues in Orleans.Example:
Kestrel registers an implementation here: https://github.com/aspnet/AspNetCore/blob/00e0b97466a3aa7e535b1e34fb04c11f5970fb28/src/Servers/Kestrel/Kestrel/src/WebHostBuilderKestrelExtensions.cs#L32
Orleans registers an implementation here:
orleans/src/Orleans.Runtime/Hosting/DefaultSiloServices.cs
Line 355 in e816f02
We can change our registration to disambiguate it from Kestrel's, but issues may occur with other users of these abstractions. I imagine the problem would also exist with
IConnectionFactory
(eg, maybe Orleans + SignalR).cc @davidfowl
The text was updated successfully, but these errors were encountered: