Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for net7.0 to dotnet.py script #2009

Closed
kunalspathak opened this issue Sep 13, 2021 · 4 comments · Fixed by #2012
Closed

Add support for net7.0 to dotnet.py script #2009

kunalspathak opened this issue Sep 13, 2021 · 4 comments · Fixed by #2012
Assignees

Comments

@kunalspathak
Copy link
Member

Currently, when we do dotnet.py install --architecture x64 --install-dir D:\workspace\_work\1\s\workitem\performance\tools\dotnet\x64 --verbose , it installs net6.0 but it should start installing net7.0

@billwert
Copy link
Member

Good call. We need to spin up a release/6.0.1xx branch in the perf repo before we can change this. Is this blocking you?

@kunalspathak
Copy link
Member Author

Yes...superpmi collection is failing with following errors:

Running: C:\h\w\B38009EC\w\ABE2096B\u\performance\tools\dotnet\x64\dotnet build C:\h\w\B38009EC\w\ABE2096B\u\performance\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework net7.0 --no-restore /p:NuGetPackageRoot=C:\h\w\B38009EC\w\ABE2096B\u\performance\artifacts\packages -o C:\h\w\B38009EC\w\ABE2096B\u\performance\artifacts
Microsoft (R) Build Engine version 17.0.0-preview-21460-01+8f208e609 for .NET

Copyright (C) Microsoft Corporation. All rights reserved.



C:\h\w\B38009EC\w\ABE2096B\u\performance\tools\dotnet\x64\sdk\6.0.100-rc.2.21460.37\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(144,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 7.0.  Either target .NET 6.0 or lower, or use a version of the .NET SDK that supports .NET 7.0. [C:\h\w\B38009EC\w\ABE2096B\u\performance\src\benchmarks\micro\MicroBenchmarks.csproj]



Build FAILED.



C:\h\w\B38009EC\w\ABE2096B\u\performance\tools\dotnet\x64\sdk\6.0.100-rc.2.21460.37\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(144,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 7.0.  Either target .NET 6.0 or lower, or use a version of the .NET SDK that supports .NET 7.0. [C:\h\w\B38009EC\w\ABE2096B\u\performance\src\benchmarks\micro\MicroBenchmarks.csproj]

    0 Warning(s)

    1 Error(s)

@DrewScoggins
Copy link
Member

Working on a fix for this now.

@DrewScoggins
Copy link
Member

DrewScoggins commented Sep 14, 2021

These three PRs should get us in a good place, but the runtime ones will have to go in first.

dotnet/runtime#59070
dotnet/runtime#59071
#2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants